#GTA SA CLEO 4 CRASH FIX MOD#
#GTA SA CLEO 4 CRASH FIX MODS#

Unfortunately the same behavior had been implemented in CLEO for III/VC so we would need to fix it there too. I would not care about any other opcode unless you can provide a clear use case when it's absolutely needed. If the script needs it, they can use global paths. As being said there never was an idea to allow scripts changing the current directory to an arbitrary path. We only need to adjust the file manipulation opcodes (open_file, create_directory, file_exists, directory_exists). Just avoid chdir by operating on any paths each script is set to use, so if they use a relative path then the dir the script last gave for chdir is prepended, or the default path is used. Regarding a possible solution, if you'd ask me I'm all for the Deji's proposal: I don't think scripts should be able to set the current directory anywhere else but that ship has sailed already. This is why initially chdir only accepted 0 and 1 to choose between the two directories. Ultimately the goal was to get access to the User Files directory, as in normal case the script should only operate within the game directory using relative paths. I think adding chdir command in user scripts was a mistake as it mutates the global state and lead to subtle bugs and race conditions. That fix should go in the direction of not using chdir to read files in User Files from another thread.ДЇYI I've sent you a CLEO.asi patched with the second fix.

#GTA SA CLEO 4 CRASH FIX MODS#

Considering CAEStreamThread behavior is so subtle and non-deterministic, probably breaking so many other mods with their authors not even noticing, a fix on that should probably be good. Thus I ask you if you could please give context on the introduction of this feature in 4.3. Chdir is prone to race conditions, using it in any form should be avoided, not encouraged.

Remove the script local chdir feature.

Would be nice if we could disable it somehow after the script does something specific, but I can't visualize what that is at the moment. In this case, script local chdir feature gets enabled.

Save a boolean indicating this script has used SET_CURRENT_DIRECTORY.=>0x777EE925 RtlEnterCriticalSection+0x15 in ntdll.dll (+0x3e925) (0x12ABFE80)Д x00823FD0 in gta-sa.exe (+0x423fd0) (0x12ABFEBC)Д¬c see the following solutions (in no particular preference order at the moment of writing): My cleo log doesn't come up with anything. Here's the crash log for when modloader is installed.

#GTA SA CLEO 4 CRASH FIX MOD#

I also found it crashes sooner if mod loader is installed. I found the best way to test this is to spam the user track skip button, it will eventually crash the game. When I have any cleo scripts installed, the game will eventually crash when using the game's user track player radio station (switching to the station, entering a vehicle or going to the next song).

Gta sa cleo 4 crash fix